Luca Favatella wrote: > Hi. > > > > I suggest the attouched patch against current svn of the "control" package. > Please review it. > > > -Added a new function named "balreal". > At the moment it is tested only with continuous time systems (not with > discrete-time ones), and its test should be improved, but I think it > is good it is committed. > I modified the INDEX file to reflect this change. > > -Added 2 new functions named "isct" and "isdt" and consider > "is_digital" obsolete. > At the moment they are only wrapper for is_digital. > I tested they are compatible with Matlab documentation for simple > systems (look at their tests). > In the long term they should be modified to be more compatible with > Matlab counterparts. > I modified the INDEX file to reflect this change. > > -Rewritten the "gram" function to be more compatible with Matlab: > added a new signature and now accept discrete-time systems. > Added tests to consider all paths in the function. > > -Modified the "dgram" function to reflect the fact that it is left > only for backward compatibility (not efficient but simple to mantain). > In fact it was even removed from Matlab documentation (but it is > present in recent version of Matlab, I think for compatibility > reason). > > -Modified the INDEX file to suggest using "is_stable" instead of the > missing "isstable" > > -Bumped package version from 1.0.8 to 1.0.9 > > Luca,
I think the control toolbox might be considered as orphaned as not much has been done on it for a few years, as you are interested in making it more compatible then you should probably be made the maintainer of this package.. The changes you propose to my naive eye all seem to make sense... That being the case and as you don't yet have an octave-forge account, what is your sourceforge username and I'll add you as a developer to octave-forge and you can commit this change yourself.. Regards David -- David Bateman dbate...@dbateman.org 35 rue Gambetta +33 1 46 04 02 18 (Home) 92100 Boulogne-Billancourt FRANCE +33 6 72 01 06 33 (Mob) ------------------------------------------------------------------------------ _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
