Søren Hauberg wrote:
> lør, 20 03 2010 kl. 19:36 +0100, skrev Michael Creel:
>> I think that replacing list with cell arrays is pretty
>> straightforward. I did that for samin and bfgsmin quite a while ago,
>> when lists were deprecated. I suggest that the authors of the
>> functions in question take care of this before Octave 3.4 appears. If
>> they don't, then functions that stop working can be moved to a "deep
>> freeze" directory, so that they can be recovered when someone has time
>> to work on them.
> 
> This is fine by me.
> 
> The following functions seem to be using lists at the moment. Unless
> they are fixed by the time Octave 3.4 is released, they will be put in a
> directory that is not installed as part of the package.
> 
>         d2_min.m
>         fminunc_compat.m
>         line_min.m
>         minimize.m
>         nelder_mead_min.m
>         test_d2_min_2.m
>         test_d2_min_3.m
>         test_fminunc_1.m
>         test_min_3.m
>         test_min_4.m
>         test_minimize_1.m
>         test_nelder_mead_min_1.m
>         deriv.m
>         optimset_compat.m
>         __semi_bracket.m
> 
> So, if you care about any of these functions, please speak up.
> 

I've replaced all list elements in optim. According to my tests, these 
tests work fine:
      test_d2_min_1         %   ok
      test_d2_min_2         %   ok
      test_d2_min_3         %   ok
      test_nelder_mead_min_2%   ok
      test_wpolyfit         %   ok
      test_min_3            %   ok

I guess, this means that most other functions (like d2_min, line_min, 
deriv, minimize, nelder_mead_min, and fminunc_compat are also fine. )

The following tests are still failing
      test_min_4            % ffailed
      test_minimize_1       %  failed
      test_nelder_mead_min_1%  failed
      test_fminunc_1        %  failed

test_min_4 fails with the following usage error:
usage: bfgsmin: 1st element of 3rd argument (iteration limit) must be 
Inf or positive integer.
Perhaps, this test is broken?
The other tests fail with a segmentation fault - so there is at least a 
problem somewhere else, too.

Is it ok to commit this these changes ?

Alois




------------------------------------------------------------------------------

_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev

Reply via email to