2012/4/30 Claudio Freire <[email protected]>:
> On Mon, Apr 30, 2012 at 10:00 AM, Jordi Gutiérrez Hermoso
> <[email protected]> wrote:
>> I'm not sure about these sort of changes:
>>
>> --- octave-forge.orig/parallel-2.0.5/src/send.cc 2012-04-29
>> 16:25:21.907000132 -0300
>> +++ octave-forge/parallel-2.0.5/src/send.cc 2012-04-29
>> 16:25:33.409000132 -0300
>> @@ -25,6 +25,7 @@
>> #include <sys/poll.h>
>> #include <netinet/in.h>
>> #include <netdb.h>
>> +#include <unistd.h>
>>
>> Octave-Forge isn't only compiled for Unix-like systems, so this
>> #include will break compilation on Windows. We probably need an
>> autoconf macro to check for unistd.h. Can you write one?
>
> In that case, you could probably wrap it in:
>
> #if (!defined(__WIN32__) && !defined(__CYGWIN__))
> #include <unistd.h>
> #endif
Although I know Octave-Forge is more lax about coding standards, I
don't think this sort of macro checking is a good idea. Instead, in
configure.ac we can do
AC_CHECK_HEADERS([unistd.h])
and then use
#if HAVE_UNISTD_H
instead.
If you don't know how to do this, I can do it myself, but I'm busy
with other things right now.
- Jordi G. H.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Octave-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/octave-dev
