On Mon, Apr 30, 2012 at 10:00 AM, Jordi Gutiérrez Hermoso
<jord...@octave.org> wrote:
> Can you please comment on the following modifications?
>
> --- octave-forge.orig/miscellaneous-1.0.11/src/xmltree_read.c
> +++ octave-forge/miscellaneous-1.0.11/src/xmltree_read.c
> @@ -2258,7 +2258,7 @@ case 49:
> XML__RULE_SETUP
> #line 406 "xmltree_read.l"
> {
> - LEAVE; STag_scalar(); pcdata = BUFFERSET(pcdata); ENTER(IN_scalar);
> + LEAVE; STag_scalar(); BUFFERSET(pcdata); ENTER(IN_scalar);
> }
> XML__BREAK
> case 50:
Building without those fixes for SLE I noticed why they're needed.
When writing "pcdata = BUFFERSET(pcdata)", the compiler issues a
warning about "warning: operation on 'pcdata' may be undefined". This
is probably because it expands to "pcdata = pcdata = next", which,
even if not incorrect, is certainly redundant. Removing the assignment
should be perfectly safe, it's already done by the macro.
In fact, I found the exact same issue in io-1.1.2
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev
