On Tue, Jul 3, 2012 at 10:59 AM, Paul Dreik <sl...@pauldreik.se> wrote:

> On 2012-07-03 11:04, Michael Goffioul wrote:
> > On Tue, Jul 3, 2012 at 9:55 AM, Paul Dreik <sl...@pauldreik.se
> > <mailto:sl...@pauldreik.se>> wrote:
> >
> >     On 2012-06-25 10:58, c. wrote:
> >     > P.S. I think there might be a typo in tis line of sockets.cc:
> >     >
> >     > DEFUNX_DLD ( "AF_LOCAL", FAFL_OCAL, FSAF_LOCAL, args, nargout,
> >     "socket constant" )
> >     > { error( "AF_LOCAL address family not supported on this platform"
> >     ); return octave_value(); };
> >     >
> >     >
> >     > shouldn't it be " FAF_LOCAL" rather than "FAFL_OCAL" ?
> >
> >     hmm, I guess you are right. this is only activated on win32 so one
> needs
> >     to try it on windows. any windows users out there?
> >
> >
> > Cannot test atm, but it's definitely a typo ('L' and '_' are swapped).
> > For reference, see [1] for a list of supported address families.
> >
> > Michael.
> >
> > [1]
> http://msdn.microsoft.com/en-us/library/windows/desktop/ms740506(v=vs.85).aspx
> >
>
> I made the change, but windows users with octave<=3.2 calling AF_LOCAL
> in octave might not see the function, which would just leave it
> undefined. this is related to the octave version macros I have been
> annoying the list with earlier.
>
> Michael, can you please test the svn version 10712 once you get around
> to it? There might be other windows related problems which would be nice
> to spot.
>

I put in attachment the put I applied on 1.0.7 version. The first and the
last hunk are already solved in SVN apparently.

Michael.

Attachment: octave-3.6.2-sockets-1.0.7-msvc.diff
Description: Binary data

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev

Reply via email to