On Nov 1, 2006, at 3:00 PM, Adam Heath wrote:
Si Chen wrote:
I don't know about the particulars of the commons-fileupload library,
but the problem with the bsf is that it interfered with the currently
used jpublish. If you can supply an upgrade combination of bsf and
jpublish that still works, I think that should work for me (and
hopefully the other committers as well.) Otherwise, given how little
the bsf library is actually used in the core ofbiz applications and
framework, it made little sense to break existing functionality
just to
get a newer version of it.
Yes, well, there is a patch from someone else from 2004(see the bug)
that fixes that. And that patch was never applied.
It's all well and good to provide patches, but if they never get
applied
by those in charge, it makes those that provide said patches reluctant
to provide more in the future.
There is no "you" and "us". OFBiz is a community driven project, so
there is only an "us". If you want something done about this sort of
problem, and it's certain a problem, then you can help. In fact there
are lots of ways you or anyone can help:
1. pay committers to review and commit patches; there is no conflict
of interest or anything wrong with this and while it's not required
to get a patch in, OFBiz is NOT A SPONSORED PROJECT, meaning no
committers are paid for anything they do with the project, unless a
client pays them for it
2. start getting involved more with OFBiz and become a committer,
this way you can help solve this problem not only for yourself, but
for everyone else as well
3. review patches that others submit to see if they cause any
problems or need changes before they can be committed; this is a
_HUGE_ problem as the majority of the patches coming in have
problems, and sometimes (like your OFBIZ-401 patch) they cause big
problems that break lots of stuff and don't improve anything material
or immediate
In general the goal of updating the libraries is a good one, but
in my
opinion it has to be well-tested so that the functionality of the
core
project is not compromised.
So, instead of going forward, fixing jpublish, you'd rather stay back?
Why does one person have to do all the work at fixing something?
What's this one person stuff? I think you need a vacation or
something to help adjust your attitude. Did you read all of the posts
about this issue on the mailing lists? Various side effects of the
patch were identified and a plan was laid out with a list of specific
things that needed to be done in order to move forward with it. One
person? Who was that one person? If anyone on this issue so far it
has been Jacopo.
-David
