For everyone: there are many ways to review a patch:
c) apply the patch and verify if the system builds and runs correctly (ant clean, ant build) with no new warnings or error messages in the log files; if xml files have been updated, check the syntax agains their xsd files using an xml parser d) test the patch by reproducing the use case scenario
This is another thing that automated testing helps with tremendously. It gives you confidence that you can modify things and be relatively sure of generating a warning if you've inadvertently broken something. -- David N. Welton - http://www.dedasys.com/davidw/ Linux, Open Source Consulting - http://www.dedasys.com/
