From: "Adam Heath" <[EMAIL PROTECTED]> > Si Chen wrote: > > I don't know about the particulars of the commons-fileupload library, > > but the problem with the bsf is that it interfered with the currently > > used jpublish. If you can supply an upgrade combination of bsf and > > jpublish that still works, I think that should work for me (and > > hopefully the other committers as well.) Otherwise, given how little > > the bsf library is actually used in the core ofbiz applications and > > framework, it made little sense to break existing functionality just to > > get a newer version of it. > > Yes, well, there is a patch from someone else from 2004(see the bug) > that fixes that. And that patch was never applied. > > It's all well and good to provide patches, but if they never get applied > by those in charge, it makes those that provide said patches reluctant > to provide more in the future.
Adam, I'm the one that commited the bsf patch and finally reverted it back. If you were aware of a problem and knew that a patch existed why did not you submitted this patch or simply tell about it ? Of course I may have figured it out myself and use the new JPublish library with your patch when I realised the problem origin. But the reason we choose not to go further is that we expect soon not to use JPublish anymore. And also because there are hotter topics around. In the future don't hesitate to submit new patches. Be sure I will be happy to review and commit them. It's always a pleasure to work with people having a good knowledge of OFBiz and its history. Thanks to share this knowledge Jacques
