The hso driver setup function tests for the devnode beginning with "hso"
in order to detect the network interface.  Since the devnode will always
begin with "/dev", this condition will never be fulfilled.

Given that the 'net' variable never gets set, we could just remove it.
However, leaving it there for now might be reminder to someone to figure
out how to set it in case it's actually needed.  That said, this test
has been in the code since 2011 and, presumably, nobody's noticied so
this modem might not be something that anybody actually uses anymore.
---
 plugins/udevng.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/plugins/udevng.c b/plugins/udevng.c
index 5b858f2..f66a8b1 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -174,9 +174,6 @@ static gboolean setup_hso(struct modem_info *modem)
                        app = info->devnode;
                else if (g_strcmp0(info->sysattr, "Modem") == 0)
                        mdm = info->devnode;
-               else if (info->sysattr == NULL &&
-                               g_str_has_prefix(info->devnode, "hso") == TRUE)
-                       net = info->devnode;
        }
 
        if (ctl == NULL || app == NULL)
-- 
2.9.3

_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to