On 03/31/2017 10:35 AM, Lukasz Nowak wrote:
Hi Jonas,

On 30/03/17 21:53, Jonas Bonn wrote:
The rule might match for some device but setup_telitqmi does not attempt
to do anything for interfaces that aren't driven by the qmi_wwan driver
so it's pointless.
As I described before, this rule is not pointless, it prevents this rule:
        { "telit",    "option",     "1bc7"                },

from taking over the device, and using setup_telit instead of setup_telitqmi.

Lukasz

Yes, but in the context of the transition to hwdb it should not be necessary anymore. That said, I see the problem and I think it still persists in the hwdb model. The problem is the Telit catch-all rule; we really need to get rid of it but that risks rendering a bunch of modems that work today non-functional. This needs some thought.

/Jonas



---
  plugins/udevng.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/plugins/udevng.c b/plugins/udevng.c
index 3aef447..d02cc6e 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -1324,7 +1324,6 @@ static struct {
        { "telit",    "usbserial",  "1bc7"                },
        { "telit",    "option",     "1bc7"                },
        { "telit",    "cdc_acm",    "1bc7", "0021"      },
-       { "telitqmi", "option",     "1bc7", "1201"      },
        { "quectel",  "option",     "05c6", "9090"      },
        { "telit",    "cdc_ncm",    "1bc7", "0036"      },
        { "telit",    "cdc_acm",    "1bc7", "0036"      },


_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to