Hi Jonas, On 03/30/2017 03:52 PM, Jonas Bonn wrote:
The hso driver setup function tests for the devnode beginning with "hso" in order to detect the network interface. Since the devnode will always begin with "/dev", this condition will never be fulfilled.
That's definitely incorrect. setup_hso will receive both ttys and network devices. ttys will start with /dev/, but network devices are not. This change would break all option devices with a high speed interface.
Given that the 'net' variable never gets set, we could just remove it. However, leaving it there for now might be reminder to someone to figure out how to set it in case it's actually needed. That said, this test has been in the code since 2011 and, presumably, nobody's noticied so this modem might not be something that anybody actually uses anymore.
'net' definitely gets set. I just tested it on an Option 452 and it works just fine.
--- plugins/udevng.c | 3 --- 1 file changed, 3 deletions(-)
Regards, -Denis _______________________________________________ ofono mailing list [email protected] https://lists.ofono.org/mailman/listinfo/ofono
