On Mon, Sep 24, 2018 at 11:00 PM Denis Kenzior <[email protected]> wrote:
> Hi Giacinto, > > On 09/23/2018 12:28 AM, Giacinto Cifelli wrote: > > also renamed the cinterion_* functions in gemalto_*. > > Eventually, the vendor cinterion will be removed. > > --- > > drivers/atmodem/sim.c | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > This is all great and all, but where are my patches for actually fixing > the use of VENDOR_CINTERION for plugins/gemalto.c? > Patience, I need to prepare everything beforehand. VENDOR_CINTERION is selected in udevng it is for serial modems, it is mainly based on the TC65i model, and apparently not properly tested for ages: back to our discussion about AT+VTS with quotes, I have discovered that it was with quotes in ofono atmodem at the beginning, most likely for the TC65i, and then removed, but not entirely: the string allocation in atmodem/voicecall.c still takes into account the room for the quotes in the code: buf = g_try_new(char, len * 9 + 3); the 9 in this command is the length of "+VTS=\"n\";". (but the command above it has been updated!) Most Gemalto modems have a serial port, that can be used in complement or instead of USB ports, and in my code I have merged VENDOR_CINTERION and VENDOR_GEMALTO. The plugin is the final part I am going to push. There are quite a few topics to discuss before I can do it. In the meanwhile, will you take this change (and related ones)? With this change, VENDOR_CINTERION works as before for now, but the internal prefixes need update. > Regards, > -Denis >
_______________________________________________ ofono mailing list [email protected] https://lists.ofono.org/mailman/listinfo/ofono
