Hi Giacinto,

But the VENDOR_CINTERION remains in the code, there are no changes for the plugin.


That's exactly the point. You have taken out all VENDOR_CINTERION logic, yet plugins/gemalto.c still sets VENDOR_CINTERION for the sim atom. So now you broke that driver. Your change set is not self-contained. If I apply this patch and you get hit by a bus tomorrow, the plugin remains broken for everyone.

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to