Hi Giacinto,

It is not taken out. It is:
        case OFONO_VENDOR_CINTERION:
        case OFONO_VENDOR_GEMALTO:
                if (g_at_chat_send(sd->chat, "AT^SPIC", gemalto_spic_prefix,
                                        gemalto_spic_cb, cbd, g_free) > 0)

both are there, and the functions are renamed, but still there.
Or shall I duplicate the functions for the time being?


Ok, I stand corrected, I assumed you removed OFONO_VENDOR_CINTERION from the sms driver.

But still, can we strive for self-contained change sets? Just take out VENDOR_CINTERION use inside the sim driver and change over to VENDOR_GEMALTO for any modem drivers that need it. That makes things much easier to follow compared to doing only the sim driver changes now and then flipping from one VENDOR to another at some later point.

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to