On 12/10/18 18:23, Giacinto Cifelli wrote:
actually:

+
+     if (g_at_chat_send(cbd->ldd->chat, buf, NULL,
+                     at_lte_set_auth_cb, cbd, g_free) > 0)
+             return;
+
Here you'll leak cbd again.
here there is a g_free in the call. Also in case of failure the g_free
is executed, I think (also because it is the same construct as
everywhere else).
Or not?

If g_at_chat_send returns 0, g_free() won't be called so you need to free the data yourself.  That should be the construct used elsewhere so if you see it done differently your seeing bugs (probably).

/Jonas

_______________________________________________
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to