Hi Denis,

>
> Then memcpy the pending structure (or the needed members) into an area
> with lifetime you control.

that's better, excellent even: I only need chat as a matter of fact.

>
> >>
> >> Why are you removing the destructor.  This will cause leaks whenever a
> >> hot-unplug event happens and this command is queued...
> >>
> >> If you want to use cbd across multiple commands, the proper way to do
> >> that is with a reference counted structure.
> >
> > is there an example elsewhere in the code?
> >
>
> drivers/ubloxmodem/netmon.c
> drivers/hfpmodem/slc.c

oh, it's done by hand. Like this I knew how to do it :)
Nevertheless, good example. I will do the same.

>
> There may be a few other places that get this wrong and should be fixed.
>   Feel free to point them out when/if you see these.

ok. It is difficult to grep because the lines are broken (and
therefore cannot grep for it), so it is just in case I step on them by
chance.

>
> Regards,
> -Denis

Regards,
Giacinto
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to