Hi Denis, On Fri, Oct 12, 2018 at 8:46 PM Denis Kenzior <[email protected]> wrote: > > Hi Giacinto, > > On 10/12/2018 01:15 PM, Giacinto Cifelli wrote: > > I have already added it. > > > > I have just greped through the code, here are some examples, from the > > end of the output: > > > > plugins/phonesim.c:18187: if (g_at_chat_send(data->chat, buf, none_prefix, > > plugins/phonesim.c-18237- set_online_cb, cbd, g_free) > 0) > > plugins/phonesim.c-18274- return; > > plugins/phonesim.c-18284- > > plugins/phonesim.c-18285- CALLBACK_WITH_FAILURE(cb, user_data); > > > > Okay, that's a bug. Fixed. > > > gatchat/gatmux.c:19544: if (g_at_chat_send(chat, "AT+CMUX=?", cmux_prefix, > > gatchat/gatmux.c-19596- mux_query_cb, msd, msd_free) > 0) > > gatchat/gatmux.c-19634- return TRUE; > > gatchat/gatmux.c-19649- > > gatchat/gatmux.c-19650- if (msd) > > gatchat/gatmux.c-19660- msd_free(msd); > > // this is actually a mistake because the msd pointer won't change, freed > > or not > > > > I don't see anything wrong here? Besides the redundant if which will > always be true.
right. my mistake. Here there is no risk to call msd_free twice. > > > drivers/xmm7modem/netmon.c:5135: if (g_at_chat_send(nmd->chat, > > "AT+XMCI=1", xmci_prefix, > > drivers/xmm7modem/netmon.c-5192- xmci_cb, cbd, g_free) > 0) > > drivers/xmm7modem/netmon.c-5223- return; > > drivers/xmm7modem/netmon.c-5233- > > drivers/xmm7modem/netmon.c-5234- CALLBACK_WITH_FAILURE(cb, data); > > And fixed this as well. > thanks. Please note that I didn't go through the entire list of results of grep, you asked for "examples". > Regards, > -Denis Regards, Giacinto _______________________________________________ ofono mailing list [email protected] https://lists.ofono.org/mailman/listinfo/ofono
