Mark J. Nelson wrote: > If you do not allow closed review, you are practically begging for teams > to circumvent the process in order to keep information private. > > Essentially, the teams in question have two legitimate goals: get > effective, timely review; and keep proprietary information private. If > your process makes those goals mutually exclusive, and the second is > mandated by contract (or patent law or whatever), then your process is > effectively denying the first goal.
If the information is contractually or legally obligated to remain private, how is the code allowed to go into OpenSolaris? Remember - this only specified open reviews as required for OpenSolaris - Sun is free to have whatever closed reviews it wants for things that are exclusively in /usr/closed (or the similar closed portions of other consolidations) or for things only in the Solaris fork of OpenSolaris. > It's broken for the reasons I described above. You're talking about > giving a project team an ultimatum: either break your legally binding > contract, or forego architectural review. No - the ultimatum is, "If you're going to open source your code via OpenSolaris, you open your ARC review" - if the code must stay closed, OpenSolaris isn't involved. Also, this is ARC review, which reviews the interfaces between components of the system, not all the details of a project's implmentation - even if we have to keep secret the details of which registers we poke in which order in a driver, do we have to keep secret changes needed to the DDI to allow that driver to work? -- -Alan Coopersmith- alan.coopersmith at sun.com Sun Microsystems, Inc. - X Window System Engineering