On Wed, Feb 10, 2010 at 02:01:49PM +1300, Ralph Versteegen wrote: > On 10 February 2010 06:55, James Paige <[email protected]> wrote: > > On Wed, Feb 10, 2010 at 06:40:46AM +1300, Ralph Versteegen wrote: > >> On 4 February 2010 04:48, James Paige <[email protected]> wrote: > >> > On Wed, Feb 03, 2010 at 07:45:34AM -0800, [email protected] > >> > wrote: > >> >> james > >> >> 2010-02-03 07:45:34 -0800 (Wed, 03 Feb 2010) > >> >> 125 > >> >> Fix a broken null-pointer check in SliceLoadFromFile() which was causing > >> >> crashes when trying to load a nonexistant filename. > >> >> --- > >> > > >> > This bug makes me wonder if anybody other than myself has actually seen > >> > GridSlice and slice clipping in a action yet? > >> > > >> A very similar bug has appeared: this time, the slice editor always > >> crashes when leaving, when deleting the reload document after saving > >> the slice tree. I'm wondering why noone else has noticed it (it's been > >> frustrating me all evening, but I put off investigating it.) > >> > >> The problem is somewhere in FreeNode while updating the previous and > >> next siblings. Somehow the value of nod is being changed to > >> nod->nextsib (I think). After labourous stepping through in gdb, it > >> seems that suddenly everything goes crazy. I think it's probably > >> another nasty FB. > > > > Hmm... I don't see the crash at all... > > I wonder what is different for me? > > > > --- > > James > > I found the problem. It's my old friend, argument passing defaulting to BYREF! > > Actually, I'm concerned that you don't see the crash. However, when I > tried the editor a few days ago, I didn't see a crash either. > > It seems impossible for it not to crash: any time you free a RELOAD > node with at least 2 children, the pointers will get messed up which > will result in a double free, null pointer dereference, etc. It > crashes for me in both windows and linux. I'm using FB 0.20 in both > cases, what are you using?
FB 0.20 on Linux (Ubuntu 9.04). I tested both with gdb and without. Still no crashes. Although I am glad you found and fixed the problem :) --- James _______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
