On 31 December 2010 23:06, James Paige <[email protected]> wrote: > On Thu, Dec 30, 2010 at 04:18:38PM -0800, [email protected] > wrote: >> teeemcee >> 2010-12-30 16:18:38 -0800 (Thu, 30 Dec 2010) >> 640 >> Remove the nativehbits array and all the code for saving/loading it in >> SAV/RSAV. Only the elemental bitsets were actually used (for no reason), and >> none of it was modifiable, so saving it in save files was more of a bug than >> a feature! > > All this cleanup you are doing lately is fantastic. Kudos! > >> However, I left rename_in_status in RSAV (which now corresponds to >> gam.hero(i).rename_in_status) because I can see some point in someday >> allowing it to be modified in-game (if you disagree, go ahead and remove >> it), and if I remove it from RSAV, that'll be a nuisance in future. (Hint: >> adding such a feature is trivial because all the code is already written... >> I just don't care enough for it to add it) > > I have no objection to it being there.
I have just realised (actually, experienced first-hand) that removing these bits means older versions of Game will give loaded heroes blank elemental bits. The rsav version number should be incremeneted. Unfortunately... IF GetChildNodeInt(node, "ver") > 0 THEN 'FIXME: this should be a user-visible pop-up warning rsav_warn "new save file on old game player. Some data might get lost" END IF Noooooo! How many times do we have run into exactly the same lack of warning messages before we learn our lesson? > --- > James _______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
