Hi Bart,

On 05/08/2011 18:26, Bart Coddens wrote:
https://bitbucket.org/bcoddens/oi-build

Looks good - only concern is the removal of cmake-2.6.2.patch.

Quite a lot of the comments it adds are a bit pointless, but there are the occasional changes that might be worth keeping:

396 - PATHS /usr/local/lib /usr/lib /usr/local/lib64 /usr/lib64 ENV LD_LIBRARY_PATH
   397 +    PATHS /usr/lib /usr/lib/32 /usr/lib/64 ENV LD_LIBRARY_PATH

   426 -  PATH_SUFFIXES lib64 lib
   427 +  PATH_SUFFIXES lib64 lib lib/32 lib/64

   482 -  PATH_SUFFIXES lib64 lib
   483 +  PATH_SUFFIXES lib64 lib lib/32 lib/64

etc

But I don't use cmake, so perhaps someone who does may have an opinion here.

Otherwise if there are no complaints, I'm happy with the commit!

Cheers,

Alasdair

_______________________________________________
oi-dev mailing list
[email protected]
http://openindiana.org/mailman/listinfo/oi-dev

Reply via email to