Hi Gordon, On 8 Aug 2011, at 21:21, Gordon Ross wrote: > So, this basically looks OK to me, however: > > The "one big path" file is an annoyance. It makes it hard to see > how much of that is just removing /usr/local from search paths, > and what is other porting stuff needed for OpenIndiana. > I would have preferred one patch file for the /usr/local removal, > and separate ones for other types of changes. (but please > note, I'm not advocating one patch per touched file)
I think it may be overkill in this instance as we're modifying a pre-existing patch from upstream, but definitely worth writing up as a style point so new patches are created that way. > And that brings up another question: Do we want to remove > /usr/local from the search paths as was done for Solaris? > I wonder why this was done? Anyone know? > Do we want to continue this change? I think it's probably to keep software built with cmake relatively "clean", sunfreeware.com and friends deposit their stuff in /usr/local, and they for example use their own libgcc etc. It wouldn't be desirable for software being built with a system gcc to pick up objects linked with a non-system gcc. Since users can explicitly add /usr/local as a search path manually if they need to, I think it's safe to keep it. If you're happy to go ahead, I'll do the commit now. I've imported the patch set into my oi-build workspace. Cheers, Alasdair _______________________________________________ oi-dev mailing list [email protected] http://openindiana.org/mailman/listinfo/oi-dev
