I simplified the code in ImageBufAlgo::over. https://github.com/StefanStavrev/oiio/commit/7fd72af845c414909aaf2bd768cec3e6444e2200
At this point, I am working only in 5 files: imagebuf.h and imagebuf.cpp imagebufalgo.h and imagebufalgo.cpp oiiotool.cpp The code in the 4 files without imagebufalgo.cpp is very simple. When you review the code please review imagebufalgo.cpp at last. If you feel like we are ready for a pull request let me know. Some questions: 1. I did couple of tests for 2D with different image sizes, offsets, regions and channels, but how can I test "over" if it works in 3D? Not just "over", how would I test the other operations later if they work for 3D? 2. I will start thinking about the next operation to work on, while you review "over". I like "contrast" since it is dead simple but at the same time introduces new challenges since it has different signature than "over". Concretely it has one input image, no alpha channels are used, user needs to give one float value on command line, etc.
_______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
