Should I have one pull request for "over"? Do you want me to instead create more pull requests, per modified file maybe? I think one pull request would be fine, the complex code is just in one file anyway, but let me know what you think.
I am afraid I can't help about type specialization, all I can say is, yes it is very important to figure this out now. All the algorithms I will do, will need such functions. Another thing I feel we should deal with now is parallel_image. We can have a single general parallel_image function, instead of one per algorithm. If you agree, how should I implement variable size argument list? C++ new standard has some new features, can I use them? Should I use va_list macro instead? Having a single function for parallelization of all the algorithms would be amazing. In summary, yes, very important to deal with these two things now. I started thinking/working on "contrast" and having all the type specialization functions and parallel_image repeating in imagebufalgo.cpp causes a real mess. Imagine 20 more algorithms and for each such functions.
_______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
