michaelweghorn added a comment.
In https://phabricator.kde.org/D8642#167020, @aacid wrote: > In https://phabricator.kde.org/D8642#165611, @michaelweghorn wrote: > > > > Open pdf file, add anotation, close app > > > You get dialog about losing changes, check that save, discard, cancel all do what they say > > > > This works as described. One additional thought on that: > > Some users may want to save the modified version to a new file instead of overwriting the existing one. While this is already possible via "File" -> "Save As" (or Ctrl+Shift+S), I think it might be helpful to add an additional button "Save as" in that dialog as well. This would also help avoid users accidently overwriting the original file. (Evince, for example only offers a "Save As" option and users switching between the two programs might not be aware of the difference at once.) > > > I disagree, does libreoffice suggest "Save As" when you do open an existing file, do some changes and close the app? Do you know of any program that does offer "Save As" in that situation? As mentioned, Evince does. Apart from that, I am currently not aware of another program that does similarly. I don't consider the "Save as" button necessary if the clarification as mentioned below is implemented. > > >> Alternatively (or in addition to that), clarifying the question in the dialog to something like "Do you want to save your changes TO THE DOCUMENT <FILENAME> or discard them?" (capital letters only here to indicate what has been added) might possibly be an option as well. > > That makes sense and is again what libreoffice does for example, will add. Thanks! LibreOffice is actually from where I adapted the idea. :-) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8642 To: aacid, mlaurent Cc: rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid
