aacid added inline comments. INLINE COMMENTS
> tobiasdeiminger wrote in generator_pdf.cpp:653 > Guess this is the same sanity check as in document.cpp, > Document::swapBackingFile, probably meaning "is it still the same document?". > Could there be situations where old page count != new page count? Or where > page count is equal, but content is completely different? Yes, sanity check in case stuff did blow up for some reasons. > tobiasdeiminger wrote in generator_pdf.cpp:655-661 > This adds a few lines of redundant code and minor special handling (wrt > PDFGenerator::image). But I shouldn't complain, don't know how to do it > better. Yes, it's 3 duplicated lines, but i honestly couldn't find a good name for the new function, so i decided to just copy them. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14752 To: aacid Cc: tobiasdeiminger, sander, okular-devel, ngraham, aacid
