ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
Thanks for all this great work on Okular's mobile interface! The search field shouldn't be touching the line below it; it should have as much padding on top as on bottom. Just needs to be vertically centered in its parent, probably. Also, instead of manufacturing your own search field, how about contributing it upstream to Kirigami? There are a number of other places where a QML-yet-non-PlasmaComponents-using desktop app (e.g. System Settings) needs a search field with a clear button. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular, ngraham Cc: ngraham, okular-devel, tfella, darcyshen, aacid
