aacid added inline comments.

INLINE COMMENTS

> CMakeLists.txt:12
>  set(QT_REQUIRED_VERSION "5.8.0")
> -set(KF5_REQUIRED_VERSION "5.44.0")
>  

I don't like this.

If you need a new kirigami or something make a vesion check and then enable 
kirigami only if X verison is available, but i don't like the general 
requirement for okular to be increased at this point

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18658

To: ognarb, #okular, ngraham
Cc: aacid, ngraham, okular-devel, tfella, darcyshen

Reply via email to