ognarb added inline comments.

INLINE COMMENTS

> aacid wrote in CMakeLists.txt:12
> I don't like this.
> 
> If you need a new kirigami or something make a vesion check and then enable 
> kirigami only if X verison is available, but i don't like the general 
> requirement for okular to be increased at this point

I'm not very familiar with cmake. That about creating a separate patch with the 
placeholder text and the bottom margin improvement and wait until Okular 
depends on 5.56 to land the rest (the clear button)?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18658

To: ognarb, #okular, ngraham
Cc: aacid, ngraham, okular-devel, tfella, darcyshen

Reply via email to