>>>>> "Mark" == Mark J Nelson <Mark.J.Nelson at Sun.COM> writes:

Mark> 116, 118-120: I think that the conditional on 118 should be
Mark> removed, and this concatenation moved to outside the loop.  Not
Mark> sure about shell rules for successive invocations, it might be
Mark> safer to manually remove ch03b.html before (re)creating it. 

Sure, I'll do that.

Mark> 126: "ch*.html" already covers everything matched by "ch*s*.html"

D'oh!  I had originally used "??" instead of "*", then changed it to "*"
at the last minute, over paranoia about whether we might someday have
more than 99 chapters or sections.  I think it'd be better to go back to

    ch??.html ch??s??.html

Mark> 125-127: should probably be prefaced with "-" so that "make clean"
Mark> doesn't fail for an already-clean directory.  

The -f means that rm will exit with status 0 even if the file is
missing.

Mark> Could combine 125 and 126, but I'm not really picky about doing
Mark> so.

I used one line per "generation" target.  I'd like to keep that
structure.  Would it help to add a comment?

mike

Reply via email to