> Mark> 126: "ch*.html" already covers everything matched by "ch*s*.html"
> 
> D'oh!  I had originally used "??" instead of "*", then changed it to "*"
> at the last minute, over paranoia about whether we might someday have
> more than 99 chapters or sections.  I think it'd be better to go back to
> 
>     ch??.html ch??s??.html

Ok

> Mark> 125-127: should probably be prefaced with "-" so that "make clean"
> Mark> doesn't fail for an already-clean directory.  
> 
> The -f means that rm will exit with status 0 even if the file is
> missing.

It will still fail if the wildcard results in no args, but since you've 
got at least one explicit (as opposed to wildcard) args on each line, I 
guess I'm OK with it.

> Mark> Could combine 125 and 126, but I'm not really picky about doing
> Mark> so.
> 
> I used one line per "generation" target.  I'd like to keep that
> structure.  Would it help to add a comment?

It's fine.  I don't have any more comments.  Thanks for your patience.

--Mark


Reply via email to