----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2059/#review2075 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java <https://reviews.apache.org/r/2059/#comment4682> java doc trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java <https://reviews.apache.org/r/2059/#comment4681> java doc trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java <https://reviews.apache.org/r/2059/#comment4683> please use camel style for methods trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/2059/#comment4684> please disgard the reorder functionality of import statements from eclipse. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/2059/#comment4685> why public static? could private work here? java doc. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/2059/#comment4686> same trim function twice and please use camel style. trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/2059/#comment4687> format. trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/2059/#comment4688> format trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/2059/#comment4689> format trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java <https://reviews.apache.org/r/2059/#comment4690> is this log needed here? trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java <https://reviews.apache.org/r/2059/#comment4691> space trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java <https://reviews.apache.org/r/2059/#comment4692> please disgard reorder import statement from eclipse settings. trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java <https://reviews.apache.org/r/2059/#comment4693> spaces in the comment trunk/core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/2059/#comment4694> tabs - Angelo K. On 2011-09-26 22:03:41, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2059/ > ----------------------------------------------------------- > > (Updated 2011-09-26 22:03:41) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > adding hadoop.next support > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java > 1175987 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1175987 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1175987 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1175987 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1175987 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java > 1175987 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1175987 > trunk/core/src/main/resources/oozie-default.xml 1175987 > > trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1175987 > > Diff: https://reviews.apache.org/r/2059/diff > > > Testing > ------- > > tested against current unit tests > > > Thanks, > > Mona > >
