> On 2011-09-26 23:30:50, Angelo K. Huang wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 990 > > <https://reviews.apache.org/r/2059/diff/1/?file=45821#file45821line990> > > > > why public static? could private work here? > > > > java doc.
yes private would be fine as this method is not being invoked by any other class object. > On 2011-09-26 23:30:50, Angelo K. Huang wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 1015 > > <https://reviews.apache.org/r/2059/diff/1/?file=45821#file45821line1015> > > > > same trim function twice and please use camel style. this function is accessed in static and non-static manner in the two places. Moving it to a common location i.e. parent class will not work in this case. changed the method name to conform to camel style - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2059/#review2075 ----------------------------------------------------------- On 2011-09-26 22:03:41, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2059/ > ----------------------------------------------------------- > > (Updated 2011-09-26 22:03:41) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > adding hadoop.next support > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java > 1175987 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1175987 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1175987 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1175987 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1175987 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java > 1175987 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1175987 > trunk/core/src/main/resources/oozie-default.xml 1175987 > > trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1175987 > > Diff: https://reviews.apache.org/r/2059/diff > > > Testing > ------- > > tested against current unit tests > > > Thanks, > > Mona > >
