> On 2011-09-27 21:39:12, Roman Shaposhnik wrote: > > I'm sorry for being a stickler, but I'd still prefer the whitespace changes > > to be separate. For one, this patch might need to be applied to a branch > > and I'd like to minimize the amount of work that needs to be done for > > merging. How difficult is it to generate the diff with -w option?
Committer may accidentally add tailing spaces to the code. We want to keep the review policy as is, so the code looks cleaner. - Angelo K. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2059/#review2121 ----------------------------------------------------------- On 2011-09-28 00:37:32, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2059/ > ----------------------------------------------------------- > > (Updated 2011-09-28 00:37:32) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > adding hadoop.next support > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java > 1175987 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1175987 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1175987 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1175987 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1175987 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java > 1175987 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1175987 > trunk/core/src/main/resources/oozie-default.xml 1175987 > > trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1175987 > > Diff: https://reviews.apache.org/r/2059/diff > > > Testing > ------- > > tested against current unit tests > > > Thanks, > > Mona > >
