[
https://issues.apache.org/jira/browse/OOZIE-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165119#comment-13165119
]
[email protected] commented on OOZIE-15:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3018/#review3737
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8426>
In general, element name could start with with "e".
so in this case, you could use eJob or eCoordJob to make it more meaning
full.
However, this is minor thing.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8429>
I know it is not the scope of this JIRA.
Bit it could relevan and could be added into this JIRA too.
For example instance.trim().length() == 0 --> means instance content is
empty. Are we checking this error case. If we do it other place, then it is
fine.
If not, we could catch it here and throw appropriate Exception or we could
create a new JIRA for that.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8427>
is there any possibility that instance could be "null". In that case adding
one more && condition would not hurt.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8428>
Since both code sections for input-events and output-events are identical,
we should write a generic method and call it with twice.
Only variables are eventName="input-events"/output-events" and instance
description "data-in"/ data-output". Rest of the code ae common. So we could
parameterize the above two variables into the new method.
- Mohammad
On 2011-12-08 04:13:55, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3018/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-08 04:13:55)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. For the coordinator input events, if there are multiple dates, it uses the
first date to resolve the data
bq. instance, instead of giving warning or error.
bq. For example:
bq. <data-in name="din1" dataset="ds1">
bq.
<instance>2010-06-11T00:30Z,2010-06-11T00:31Z,2010-06-11T00:32Z</instance>
bq. </data-in>
bq.
bq. Similarly for output events.
bq.
bq. This patch will give error for the above case and protect against
submission of job that defaults to the first date without the knowledge of user.
bq.
bq.
bq. This addresses bug OOZIE-15.
bq. https://issues.apache.org/jira/browse/OOZIE-15
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
1209756
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
1209756
bq.
bq. Diff: https://reviews.apache.org/r/3018/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. yes
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> Coordinator input event instance should limit 1 instance
> --------------------------------------------------------
>
> Key: OOZIE-15
> URL: https://issues.apache.org/jira/browse/OOZIE-15
> Project: Oozie
> Issue Type: Bug
> Reporter: Mona Chitnis
> Priority: Minor
> Labels: event, oozie
> Attachments: OOZIE-15.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> for the input events, if there are multiple dates, it uses the first date to
> resolve the data
> instance, instead of giving warning or error. for example:
> <data-in name="din1" dataset="ds1">
> <instance>2010-06-11T00:30Z,2010-06-11T00:31Z,2010-06-11T00:32Z</instance>
> </data-in>
> Missing Dependencies :
> hdfs://gsbl90390.blue.ygrid.yahoo.com:8020/user/mchiang/coord-input/2010/06/11/00/30/_SUCCESS
> similarly, there is no warning or error when applying dateOffset with count >
> 1.
> <data-in name="din1" dataset="ds1">
> <instance>${coord:dateOffset(baseDate,30,'MINUTE',5)}</instance>
> </data-in>
> 1. dateOffset no longer has 4th argument, count.
> 2. however, there is no error or warning when in coordinator.xml:
> <input-events>
> <data-in name="din1" dataset="ds1">
> <instance>${coord:current(-2)},${coord:current(-1)}</instance>
> </data-in>
> </input-events>
> it resolved to use ${coord:current(-2)} only.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
