[
https://issues.apache.org/jira/browse/OOZIE-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165782#comment-13165782
]
[email protected] commented on OOZIE-15:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3018/#review3767
-----------------------------------------------------------
Some more comments.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8527>
Create string constants for input-events, data-in, output-events and
data-out. Since you will need them further down in the code, the code will look
cleaner and more manageable.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8524>
Please change the variable name to reflect the data type, i.e.,
instanceSpecList
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8528>
Use the string constants referred to in earlier comment on line # 218
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8529>
Use the string constants referred to in earlier comment on line # 218
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8530>
Lines 133-136 can be replaced with
assertTrue(e.getMessage().contains("input-events") &&
e.getMessage().contains("per data-in instance"));
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8531>
Lines 165-168 can be replaced with
assertTrue(e.getMessage().contains("input-events") &&
e.getMessage().contains("is empty"));
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8532>
Lines 237-240 can be replaced with
assertTrue(e.getMessage().contains("output-events") &&
e.getMessage().contains("can have only one <instance> tag per data-out
instance"));
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8533>
Lines 269-272 can be replaced with
assertTrue(e.getMessage().contains("output-events") &&
e.getMessage().contains("is empty"));
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
<https://reviews.apache.org/r/3018/#comment8534>
Lines 301-304 can be replaced with
assertTrue(e.getMessage().contains("No child element is expected at this
point"));
- Santhosh
On 2011-12-08 23:43:53, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3018/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-08 23:43:53)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. For the coordinator input events, if there are multiple dates, it uses the
first date to resolve the data
bq. instance, instead of giving warning or error.
bq. For example:
bq. <data-in name="din1" dataset="ds1">
bq.
<instance>2010-06-11T00:30Z,2010-06-11T00:31Z,2010-06-11T00:32Z</instance>
bq. </data-in>
bq.
bq. Similarly for output events.
bq.
bq. This patch will give error for the above case and protect against
submission of job that defaults to the first date without the knowledge of user.
bq.
bq.
bq. This addresses bug OOZIE-15.
bq. https://issues.apache.org/jira/browse/OOZIE-15
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
1209756
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
1209756
bq.
bq. Diff: https://reviews.apache.org/r/3018/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. yes
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> Coordinator input event instance should limit 1 instance
> --------------------------------------------------------
>
> Key: OOZIE-15
> URL: https://issues.apache.org/jira/browse/OOZIE-15
> Project: Oozie
> Issue Type: Bug
> Reporter: Mona Chitnis
> Priority: Minor
> Labels: event, oozie
> Attachments: OOZIE-15.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> for the input events, if there are multiple dates, it uses the first date to
> resolve the data
> instance, instead of giving warning or error. for example:
> <data-in name="din1" dataset="ds1">
> <instance>2010-06-11T00:30Z,2010-06-11T00:31Z,2010-06-11T00:32Z</instance>
> </data-in>
> Missing Dependencies :
> hdfs://gsbl90390.blue.ygrid.yahoo.com:8020/user/mchiang/coord-input/2010/06/11/00/30/_SUCCESS
> similarly, there is no warning or error when applying dateOffset with count >
> 1.
> <data-in name="din1" dataset="ds1">
> <instance>${coord:dateOffset(baseDate,30,'MINUTE',5)}</instance>
> </data-in>
> 1. dateOffset no longer has 4th argument, count.
> 2. however, there is no error or warning when in coordinator.xml:
> <input-events>
> <data-in name="din1" dataset="ds1">
> <instance>${coord:current(-2)},${coord:current(-1)}</instance>
> </data-in>
> </input-events>
> it resolved to use ${coord:current(-2)} only.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
