[
https://issues.apache.org/jira/browse/OOZIE-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166543#comment-13166543
]
[email protected] commented on OOZIE-15:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3018/
-----------------------------------------------------------
(Updated 2011-12-09 20:45:36.521024)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
Review comments incorporated
1. Test cases updated. Removed use of large strings to specify coord app xml
and implemented reading from resource files instead. Resource xml files for the
different test case scenarios added.
2. Introduced string constants for text like "input-events", "data-in" etc for
reusability and readability.
Summary
-------
For the coordinator input events, if there are multiple dates, it uses the
first date to resolve the data
instance, instead of giving warning or error.
For example:
<data-in name="din1" dataset="ds1">
<instance>2010-06-11T00:30Z,2010-06-11T00:31Z,2010-06-11T00:32Z</instance>
</data-in>
Similarly for output events.
This patch will give error for the above case and protect against submission of
job that defaults to the first date without the knowledge of user.
This addresses bug OOZIE-15.
https://issues.apache.org/jira/browse/OOZIE-15
Diffs (updated)
-----
trunk/core/src/test/resources/coord-multiple-input-instance3.xml PRE-CREATION
trunk/core/src/test/resources/coord-multiple-output-instance1.xml
PRE-CREATION
trunk/core/src/test/resources/coord-multiple-output-instance2.xml
PRE-CREATION
trunk/core/src/test/resources/coord-multiple-output-instance3.xml
PRE-CREATION
trunk/core/src/test/resources/coord-multiple-input-instance1.xml PRE-CREATION
trunk/core/src/test/resources/coord-multiple-input-instance2.xml PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
1209756
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
1209756
Diff: https://reviews.apache.org/r/3018/diff
Testing
-------
yes
Thanks,
Mona
> Coordinator input event instance should limit 1 instance
> --------------------------------------------------------
>
> Key: OOZIE-15
> URL: https://issues.apache.org/jira/browse/OOZIE-15
> Project: Oozie
> Issue Type: Bug
> Reporter: Mona Chitnis
> Priority: Minor
> Labels: event, oozie
> Attachments: OOZIE-15.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> for the input events, if there are multiple dates, it uses the first date to
> resolve the data
> instance, instead of giving warning or error. for example:
> <data-in name="din1" dataset="ds1">
> <instance>2010-06-11T00:30Z,2010-06-11T00:31Z,2010-06-11T00:32Z</instance>
> </data-in>
> Missing Dependencies :
> hdfs://gsbl90390.blue.ygrid.yahoo.com:8020/user/mchiang/coord-input/2010/06/11/00/30/_SUCCESS
> similarly, there is no warning or error when applying dateOffset with count >
> 1.
> <data-in name="din1" dataset="ds1">
> <instance>${coord:dateOffset(baseDate,30,'MINUTE',5)}</instance>
> </data-in>
> 1. dateOffset no longer has 4th argument, count.
> 2. however, there is no error or warning when in coordinator.xml:
> <input-events>
> <data-in name="din1" dataset="ds1">
> <instance>${coord:current(-2)},${coord:current(-1)}</instance>
> </data-in>
> </input-events>
> it resolved to use ${coord:current(-2)} only.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
