----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3069/#review3954 -----------------------------------------------------------
/trunk/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java <https://reviews.apache.org/r/3069/#comment8934> we are adding a mechanism to allow custom authentications, still the logic here is pretty much wired. How about the following: Having a protected method Map<String,Class<? extends Authenticator>> getAuthenticators() { ... } The Apache implementation would have the following entries: null -> KerberosAuthenticator simple -> PseudoAuthenticator kerberos -> KerberosAuthenticator then the logic is quite simple: Authenticator authClass = getAuthenticators().get(authOptionValue); if (authClass == null) { throw INVALID AUTH MECHANISM } Authenticator auth = authClass.newInstance(); .newInstance(); if - Alejandro On 2011-12-10 01:24:41, Angelo K. Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3069/ > ----------------------------------------------------------- > > (Updated 2011-12-10 01:24:41) > > > Review request for oozie. > > > Summary > ------- > > This improvement is mainly to add client parameter options to handle user > specified authentication option. In Oozie-77, client authentication uses > fall-back strategy to handle authentication, such as kerberos -> simple. User > should allow to give parameter or property to specify which authentication to > use. > > A proposal is : > > -auth simple > -auth kerberos > -auth <auth_name> > > > This addresses bug OOZIE-624. > https://issues.apache.org/jira/browse/OOZIE-624 > > > Diffs > ----- > > /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1209346 > /trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1209346 > /trunk/core/src/main/conf/oozie-site.xml 1209346 > /trunk/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java > 1209346 > > Diff: https://reviews.apache.org/r/3069/diff > > > Testing > ------- > > > Thanks, > > Angelo K. > >
