----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3069/#review5863 -----------------------------------------------------------
Why not pass as -auth the authenticator class (as it is can be done via ENV var as well)? By doing this you wouldn't have to subclass AuthOozieClient to add a new authentication. You'd just add the JAR with it and at oozie script (if you want to make things easier for users) resolve the class based on a an alias -auth foo becomes -auth my.foo.bar /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/3069/#comment12775> *user_defined* does not apply to this code (but, I assume, to a custom subclass). this message (at this class) should be 'simple|kerberos' only. /trunk/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java <https://reviews.apache.org/r/3069/#comment12769> not to break backwards compatibility, create a new constructor with the new signature /trunk/docs/src/site/twiki/ENG_Custom_Authentication.twiki <https://reviews.apache.org/r/3069/#comment12776> why this method is needed in the docs? - Alejandro On 2012-03-10 03:37:03, Angelo K. Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3069/ > ----------------------------------------------------------- > > (Updated 2012-03-10 03:37:03) > > > Review request for oozie. > > > Summary > ------- > > This improvement is mainly to add client parameter options to handle user > specified authentication option. In Oozie-77, client authentication uses > fall-back strategy to handle authentication, such as kerberos -> simple. User > should allow to give parameter or property to specify which authentication to > use. > > A proposal is : > > -auth simple > -auth kerberos > -auth <auth_name> > > > This addresses bug OOZIE-624. > https://issues.apache.org/jira/browse/OOZIE-624 > > > Diffs > ----- > > /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1298705 > /trunk/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java > 1298705 > /trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java > 1298705 > /trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java > 1298705 > /trunk/core/pom.xml 1298705 > /trunk/core/src/main/conf/oozie-site.xml 1298705 > /trunk/core/src/main/resources/oozie-default.xml 1298705 > /trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1298705 > /trunk/docs/src/site/twiki/ENG_Custom_Authentication.twiki PRE-CREATION > /trunk/docs/src/site/twiki/index.twiki 1298705 > > Diff: https://reviews.apache.org/r/3069/diff > > > Testing > ------- > > > Thanks, > > Angelo K. > >
