> On 2012-01-10 03:23:10, Mohamed Battisha wrote: > > any reasons for moving the list methods from the CoordRerunXCommand to the > > CoordUtility > > it seems to be very related to the rerun command
These methods are being used by rerun command but very similar list methods also exist for retrieving logs for date and action range. So already there is some repetition of these functions. As they are generic methods for parsing date and action ranges, have moved them to the utility class. - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3441/#review4290 ----------------------------------------------------------- On 2012-01-10 02:05:54, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3441/ > ----------------------------------------------------------- > > (Updated 2012-01-10 02:05:54) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > https://issues.apache.org/jira/browse/OOZIE-651 > > > This addresses bug OOZIE-651. > https://issues.apache.org/jira/browse/OOZIE-651 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java > 1229389 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1229389 > trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 > trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 > trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 1229389 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java > 1229389 > trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java > PRE-CREATION > trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 > > Diff: https://reviews.apache.org/r/3441/diff > > > Testing > ------- > > Tested against current test cases > Test cases for CoordUtils added > Ran the coordinator rerun example > > > Thanks, > > Virag > >
