----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3441/#review4337 -----------------------------------------------------------
sounds good, minor comments trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/3441/#comment9767> it will be better if you check for the validity of the date and throw an exception if it is not valid, instead of catching a generic exception trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/3441/#comment9772> check for null before adding to the set trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/3441/#comment9773> catching specific exception will be better trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/3441/#comment9774> you may specify what is wrong here .. it should be greater than 2 trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/3441/#comment9775> specify what is wrong will be easy to debug trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java <https://reviews.apache.org/r/3441/#comment9770> catching the specific exception would be better - Mohamed On 2012-01-10 02:05:54, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3441/ > ----------------------------------------------------------- > > (Updated 2012-01-10 02:05:54) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > https://issues.apache.org/jira/browse/OOZIE-651 > > > This addresses bug OOZIE-651. > https://issues.apache.org/jira/browse/OOZIE-651 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java > 1229389 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1229389 > trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 > trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 > trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 1229389 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java > 1229389 > trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java > PRE-CREATION > trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 > > Diff: https://reviews.apache.org/r/3441/diff > > > Testing > ------- > > Tested against current test cases > Test cases for CoordUtils added > Ran the coordinator rerun example > > > Thanks, > > Virag > >
