> On 2012-01-12 03:18:42, Mohamed Battisha wrote: > > trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java, line 65 > > <https://reviews.apache.org/r/3441/diff/1/?file=67422#file67422line65> > > > > I am assuming this is just copy and paste from the rerunXCommand
getCoordActionsFromIds() is copy and paste, getCoordActionsFromDates() has been refactored a bit to use logic from CoordActionsInDateRange class. > On 2012-01-12 03:18:42, Mohamed Battisha wrote: > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java, > > line 460 > > <https://reviews.apache.org/r/3441/diff/1/?file=67421#file67421line460> > > > > what if a null coordActions is returned. you may end up with NPE Nope.. ParamChecker.null() has been added in the next function accessing coordActions - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3441/#review4325 ----------------------------------------------------------- On 2012-01-10 02:05:54, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3441/ > ----------------------------------------------------------- > > (Updated 2012-01-10 02:05:54) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > https://issues.apache.org/jira/browse/OOZIE-651 > > > This addresses bug OOZIE-651. > https://issues.apache.org/jira/browse/OOZIE-651 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java > 1229389 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1229389 > trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 > trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 > trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 1229389 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java > 1229389 > trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java > PRE-CREATION > trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 > > Diff: https://reviews.apache.org/r/3441/diff > > > Testing > ------- > > Tested against current test cases > Test cases for CoordUtils added > Ran the coordinator rerun example > > > Thanks, > > Virag > >
