> On 2012-02-28 07:53:29, Mohammad Islam wrote: > > Overall what is the benefit? Does it mean ActionEnnComand is called for > > terminal states and all other transitions are failing to send notification? > >
the actionendcommands are called when the action ends but before the workflowlib resolves the transition, thus transition replacement is always NULL, thus this fix. > On 2012-02-28 07:53:29, Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java, > > line 190 > > <https://reviews.apache.org/r/4080/diff/1/?file=86201#file86201line190> > > > > Shouldn't we queue the NotifcationCommand here too? > > Same for FAILED at 198. good point, i'll update the patch. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4080/#review5387 ----------------------------------------------------------- On 2012-02-28 05:10:52, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4080/ > ----------------------------------------------------------- > > (Updated 2012-02-28 05:10:52) > > > Review request for oozie. > > > Summary > ------- > > Moved notification command queuing to signal command, once the transition has > been computed. > > > This addresses bug OOZIE-701. > https://issues.apache.org/jira/browse/OOZIE-701 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndCommand.java > 1294462 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1294462 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalCommand.java > 1294462 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1294462 > trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1294462 > > Diff: https://reviews.apache.org/r/4080/diff > > > Testing > ------- > > Modified TestDagEngine to test callback URL for actions > > > Thanks, > > Alejandro > >
