> On 2012-03-01 03:07:53, Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java, > > line 191 > > <https://reviews.apache.org/r/4080/diff/2/?file=86274#file86274line191> > > > > Do we need to add queue(Noti...)? > > or it is done in ActionKillXCommand
as you said, this is done in the ActionKillXCommand - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4080/#review5480 ----------------------------------------------------------- On 2012-02-28 18:14:39, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4080/ > ----------------------------------------------------------- > > (Updated 2012-02-28 18:14:39) > > > Review request for oozie. > > > Summary > ------- > > Moved notification command queuing to signal command, once the transition has > been computed. > > > This addresses bug OOZIE-701. > https://issues.apache.org/jira/browse/OOZIE-701 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndCommand.java > 1294754 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1294754 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalCommand.java > 1294754 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1294754 > trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1294754 > > Diff: https://reviews.apache.org/r/4080/diff > > > Testing > ------- > > Modified TestDagEngine to test callback URL for actions > > > Thanks, > > Alejandro > >
