> On 2012-02-28 05:43:27, Mohamed Battisha wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndCommand.java, > > line 135 > > <https://reviews.apache.org/r/4080/diff/1/?file=86198#file86198line135> > > > > Do we need to change the command classes? > > I am assuming they are already absolute.
until we remove the old commands I'd try to keep them in sync. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4080/#review5385 ----------------------------------------------------------- On 2012-02-28 05:10:52, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4080/ > ----------------------------------------------------------- > > (Updated 2012-02-28 05:10:52) > > > Review request for oozie. > > > Summary > ------- > > Moved notification command queuing to signal command, once the transition has > been computed. > > > This addresses bug OOZIE-701. > https://issues.apache.org/jira/browse/OOZIE-701 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndCommand.java > 1294462 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1294462 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalCommand.java > 1294462 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1294462 > trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1294462 > > Diff: https://reviews.apache.org/r/4080/diff > > > Testing > ------- > > Modified TestDagEngine to test callback URL for actions > > > Thanks, > > Alejandro > >
