-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3752/
-----------------------------------------------------------
(Updated 2012-03-07 09:43:36.390658)
Review request for oozie.
Changes
-------
1. Changed resolveInstanceRange to work with instance evaluations. Calls to
getFuncType from other code work with resolved instances and don't need to be
fixed
2. Made some functions in CoordELFunctions public so that they can be used for
EL extensions
3. Added example EL extensions and testcases
Summary
-------
I have an EL extension today(0,0) which maps to start day of nominal time. This
is used to specify startInstance, endInstance and instance in dataIn and
dataOut of coordinator.
In CoordCommandUtils.resolveInstanceRange(), getInstanceNumber has to return
the instance number with respect to current. So, for coord-action-create-inst
context, I have mapped today to current and hence getInstanceNumber returns the
correct number. But later in resolveInstanceRange(), getFuncType is called with
startInstance value which is today in this case and it maps to UNEXPECTED and
throws up. getFuncType should be passed the evaluation of
coord-action-create-inst context
This addresses bug OOZIE-674.
https://issues.apache.org/jira/browse/OOZIE-674
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
1297889
trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1297889
trunk/core/src/test/java/org/apache/oozie/command/coord/CoordELExtension.java
PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java
PRE-CREATION
trunk/core/src/test/resources/oozie-site-coordel.xml PRE-CREATION
Diff: https://reviews.apache.org/r/3752/diff
Testing
-------
UT - TestCoordActionMaterializeCommand
Tested with coord:current instance range and EL extension
Thanks,
shwethags
