> On 2012-03-12 17:24:08, Alejandro Abdelnur wrote: > > Any reason for these new functions to be in an coordext: namespace as > > opposed to the coord: namespace? > > shwethags wrote: > It can be in any namespace. The reason I used a different namespace is to > signify that its an extension and not in-built oozie EL function.
Shwetha, I think it would be a good addition to the built-in Oozie EL functions, would you mind making the changes so it is coord: ? Also we should add it to the coord spec list of EL functions. Thanks!!! Alejandro - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3752/#review5838 ----------------------------------------------------------- On 2012-03-07 09:43:36, shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3752/ > ----------------------------------------------------------- > > (Updated 2012-03-07 09:43:36) > > > Review request for oozie. > > > Summary > ------- > > I have an EL extension today(0,0) which maps to start day of nominal time. > This is used to specify startInstance, endInstance and instance in dataIn and > dataOut of coordinator. > > In CoordCommandUtils.resolveInstanceRange(), getInstanceNumber has to return > the instance number with respect to current. So, for coord-action-create-inst > context, I have mapped today to current and hence getInstanceNumber returns > the correct number. But later in resolveInstanceRange(), getFuncType is > called with startInstance value which is today in this case and it maps to > UNEXPECTED and throws up. getFuncType should be passed the evaluation of > coord-action-create-inst context > > > This addresses bug OOZIE-674. > https://issues.apache.org/jira/browse/OOZIE-674 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1297889 > trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1297889 > > trunk/core/src/test/java/org/apache/oozie/command/coord/CoordELExtension.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java > PRE-CREATION > trunk/core/src/test/resources/oozie-site-coordel.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/3752/diff > > > Testing > ------- > > UT - TestCoordActionMaterializeCommand > Tested with coord:current instance range and EL extension > > > Thanks, > > shwethags > >
