----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3752/#review5979 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java <https://reviews.apache.org/r/3752/#comment12970> I am not sure why you move these lines out. There is no difference before and after. You still call this function before you call getInstanceNumber(). trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java <https://reviews.apache.org/r/3752/#comment12967> Please extends from XDataTestCase instead of XTestCase. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java <https://reviews.apache.org/r/3752/#comment12966> There is add coord job method in XDataTestCase. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java <https://reviews.apache.org/r/3752/#comment12969> You can read app xml from file. You can take a look at the example from XDataTestCase.addRecordToCoordJobTable(). trunk/core/src/test/resources/oozie-site-coordel.xml <https://reviews.apache.org/r/3752/#comment12968> Since the order is currentMonth and today, you should use same order here. - Angelo K. On 2012-03-07 09:43:36, shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3752/ > ----------------------------------------------------------- > > (Updated 2012-03-07 09:43:36) > > > Review request for oozie. > > > Summary > ------- > > I have an EL extension today(0,0) which maps to start day of nominal time. > This is used to specify startInstance, endInstance and instance in dataIn and > dataOut of coordinator. > > In CoordCommandUtils.resolveInstanceRange(), getInstanceNumber has to return > the instance number with respect to current. So, for coord-action-create-inst > context, I have mapped today to current and hence getInstanceNumber returns > the correct number. But later in resolveInstanceRange(), getFuncType is > called with startInstance value which is today in this case and it maps to > UNEXPECTED and throws up. getFuncType should be passed the evaluation of > coord-action-create-inst context > > > This addresses bug OOZIE-674. > https://issues.apache.org/jira/browse/OOZIE-674 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1297889 > trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1297889 > > trunk/core/src/test/java/org/apache/oozie/command/coord/CoordELExtension.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java > PRE-CREATION > trunk/core/src/test/resources/oozie-site-coordel.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/3752/diff > > > Testing > ------- > > UT - TestCoordActionMaterializeCommand > Tested with coord:current instance range and EL extension > > > Thanks, > > shwethags > >
