> On 2012-03-08 20:34:17, Mona Chitnis wrote:
> > There is another type of EL expression of the format e.g.
> > ${coord:future(start_instance,max_instance)} that needs to be tested. This
> > type carries a "comma" within the function.
Srikanth, looks good. Would be possible to have a negative test as well?
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4222/#review5747
-----------------------------------------------------------
On 2012-03-08 15:08:40, Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4222/
> -----------------------------------------------------------
>
> (Updated 2012-03-08 15:08:40)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> checkMultipleTimeInstances doesn't work for EL extensions. EX:
> ${coord:formatTime(coord:current(0),'yyyy-MM-dd')}
>
>
> This addresses bug OOZIE-675.
> https://issues.apache.org/jira/browse/OOZIE-675
>
>
> Diffs
> -----
>
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
> 1297367
> trunk/core/src/main/java/org/apache/oozie/util/ELEvaluator.java 1297367
>
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
> 1297367
> trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1297367
> trunk/core/src/test/resources/coord-multiple-output-instance4.xml
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4222/diff
>
>
> Testing
> -------
>
> * New test case added to TestCoordSubmitXCommand.java for verifying the
> changes
> * Added additional test cases to TestELEvaluator.java as well
>
>
> Thanks,
>
> Srikanth
>
>
