----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4222/#review5956 -----------------------------------------------------------
Ship it! Ship it after 2 minor suggestions. I've tested the patch locally. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java <https://reviews.apache.org/r/4222/#comment12927> Should be CASE 4 trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java <https://reviews.apache.org/r/4222/#comment12926> minor space - Mona On 2012-03-09 11:06:47, Srikanth Sundarrajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4222/ > ----------------------------------------------------------- > > (Updated 2012-03-09 11:06:47) > > > Review request for oozie. > > > Summary > ------- > > checkMultipleTimeInstances doesn't work for EL extensions. EX: > ${coord:formatTime(coord:current(0),'yyyy-MM-dd')} > > > This addresses bug OOZIE-675. > https://issues.apache.org/jira/browse/OOZIE-675 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1297367 > trunk/core/src/main/java/org/apache/oozie/util/ELEvaluator.java 1297367 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > 1297367 > trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1297367 > trunk/core/src/test/resources/coord-multiple-input-instance4.xml > PRE-CREATION > trunk/core/src/test/resources/coord-multiple-output-instance4.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/4222/diff > > > Testing > ------- > > * New test case added to TestCoordSubmitXCommand.java for verifying the > changes > * Added additional test cases to TestELEvaluator.java as well > > > Thanks, > > Srikanth > >
